Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

819-4 wails improvement: execute SC, refactor #833

Merged
merged 5 commits into from
Nov 8, 2023
Merged

819-4 wails improvement: execute SC, refactor #833

merged 5 commits into from
Nov 8, 2023

Conversation

Thykof
Copy link
Contributor

@Thykof Thykof commented Nov 7, 2023

No description provided.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (17d7f7c) 54.33% compared to head (595e8cd) 54.44%.
Report is 1 commits behind head on main.

❗ Current head 595e8cd differs from pull request most recent head 384c8fb. Consider uploading reports for the commit 384c8fb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
+ Coverage   54.33%   54.44%   +0.11%     
==========================================
  Files          41       41              
  Lines        2343     2349       +6     
==========================================
+ Hits         1273     1279       +6     
  Misses        896      896              
  Partials      174      174
Files Coverage Δ
pkg/types/public_key.go 30.23% <100.00%> (ø)
pkg/utils/errors.go 0.00% <ø> (ø)
pkg/wallet/account/testUtils.go 100.00% <100.00%> (ø)
internal/handler/wallet/rolls.go 68.96% <50.00%> (ø)
internal/handler/wallet/sign_message.go 55.73% <0.00%> (ø)
internal/handler/wallet/transfer.go 66.23% <0.00%> (ø)
pkg/wallet/account/account.go 60.81% <0.00%> (ø)
internal/handler/wallet/sign.go 56.73% <69.64%> (+0.94%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pivilartisant
pivilartisant approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from 819-3 to main November 8, 2023 15:31
@Thykof Thykof marked this pull request as ready for review November 8, 2023 15:31
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thykof Thykof merged commit f9e6aa6 into main Nov 8, 2023
@Thykof Thykof deleted the 819-4 branch November 8, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjah peterjah peterjah approved these changes

@pivilartisant pivilartisant pivilartisant approved these changes

@mazmassa mazmassa Awaiting requested review from mazmassa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thykof @peterjah @pivilartisant